Hi zz,

The code appears to do what you want it to do; I do have some suggestions for your coding style though:

1) good of use comments, but I believe good code requires less comments if you use better variable names and descriptions, and match these to any comments that you do use;

2) think carefully about what each line of code does, logically, and try to discover if there is a "better" way to achieve the result;

3) try to make the code adaptable to changes. In your code, if you changed the "event", would the comments and code still make sense?

4) depending on how you define your "drawdown" it might make more sense to use HIGH and LOW as appropriate instead of P?

5) try to handle as many possible sources of MS errors as you can. This will make the code more applicable to different data sets.

6) consider the ramifications of N/A bars at the LHS or RHS of the chart. Do they make a difference to you and what you are trying to achieve? Do you need to perform some sort of initialisation to avoid these? Are there other functions which would avoid these N/A bars?

------------

plot:=Input("1=Bars Since Event,2=% Drawdown Since Event",1,2,1);

{the "event"}
{the current bar is a new highest value}
event:=P>Ref(Highest(P),-1);

{lowest data value since the event}
lowestSinceEvent:=If(event,P,LowestSince(1,event,P));

{highest data value since the event}
{this is just the highest charted value, so can be computed simply as:}
highestSinceEvent:=Highest(P);

{but, just in case you change the definition of the event, it is safer to use:}
highestSinceEvent:=If(event,P,HighestSince(1,event,P));

{% peak to trough, includes DBZ error handling}
drawdown:=100*(highestSinceEvent-lowestSinceEvent)/Max(highestSinceEvent,Power(10,-8));

{plot in new inner window}
If(plot=1,BarsSince(event),drawdown);

------------

That's all I have time for now. I may take another look later?



Hope this helps.

wabbit [:D]


P.S. Where possible, please don't address forum posts to individuals. If you want someone in particular to have a look at your work, please send them an email or PM (be cognisant that Administrators and Moderators receive a lot messages and may not necessarily answer all of them, in the timeframe you expect or at all!). The forum is a place for everyone to share; if you ask an individual for assistance and that person is away, your post may not get answered because other members might think it is not their place to post a response when the original post was not intended for them. It can cause confusion, and as such, should be avoided.