i created this system by zigzag
buy:
cross(Zig(c ,opt1 , %) , ref( Zig(c ,opt1 , %),-1))
sell:
cross(ref( Zig(c ,opt1 , %),-1),Zig(c ,opt1 , %))

it gives me a very good result in a tick data and i wrote it in the expert advisor when i attache this expert to the chart i found this problem:
sometimes it give me a signal (buy or sell) but after some bars it remove the given signal.
this make me confused if i take buy or sell signal then it remove it what i can do.

Thanks ,
but where can i use this indicator to get benefit from it.

Hi MS Support

Thank you, I've learned something new today, namely that Peak and Trough values do not change until the last leg has been confirmed.

However, this doesn't change the fact that Peak, Trough, PeakBars and TroughBars are dynamic - once the last leg has been confirmed these functions change their value for all bars back to the now confirmed peak or trough. So while they might have some value, I'm with Henry and believe they should never be used with mechanical systems. A signal that changes (other than on the hard right edge) renders any system it's used with impossible to back-test, and most likely very risky to trade.

Roy

{ZigZag validity engine by Spyros Raftopoulos}
{additional code by Jose Silva}
{1=ZigZag valid, 0=ZigZag invalid}

perc:=Input("ZigZag percent",.1,100,5);
plot:=Input("plot: signals=1, % of valid signals=2, ZigZag=3",1,3,
1);
x:=Input("use Open=1 High=2 Low=3 Close=4 Volume=5 P=6",1,6,4);

x:=If(x=1,O,If(x=2,H,If(x=3,L,If(x=5,V,If(x=6,P,C)))));
z:=Zig(x,perc,%);
z1:=Ref(z,-1);
z2:=Ref(z,-2);
last:=ValueWhen(1,z>z1 AND z1<z2
OR z<z1 AND z1>z2,z1);
pc:=Abs((x-last)*100/last);
SD:=z>z1 AND z1>z2 OR z<z1 AND z1<z2;
res:=pc>=perc;
valid:=If(Alert(res,2) AND SD,1,res);
validper:=Cum(valid)/Cum(valid>-1)*100;

If(plot=3,z,If(plot=2,validper,valid))

ZigZag Targets

x:=Input("number of time periods in average",10,200,40);
x2:=x*2;
pd:=C-Mov(C,x,E);
hpd:=HHV(pd,x2);
lpd:=LLV(pd,x2);
nf:=200/(hpd-lpd);
((pd-lpd)*nf)-100